On Wed, 2024-07-24 at 06:51 -0400, Michael S. Tsirkin wrote:
> with max-bytes set to 0, quota is 0 and so device does not work.
> block this to avoid user confusion
>
> Signed-off-by: Michael S. Tsirkin <m...@redhat.com>
> ---
> hw/virtio/virtio-rng.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
> index f74efffef7..7cf31da071 100644
> --- a/hw/virtio/virtio-rng.c
> +++ b/hw/virtio/virtio-rng.c
> @@ -184,8 +184,9 @@ static void virtio_rng_device_realize(DeviceState
> *dev, Error **errp)
>
> /* Workaround: Property parsing does not enforce unsigned
> integers,
> * So this is a hack to reject such numbers. */
> - if (vrng->conf.max_bytes > INT64_MAX) {
> - error_setg(errp, "'max-bytes' parameter must be non-
> negative, "
> + if (vrng->conf.max_bytes == 0 ||
> + vrng->conf.max_bytes > INT64_MAX) {
> + error_setg(errp, "'max-bytes' parameter must be positive, "
> "and less than 2^63");
> return;
> }
Reviewed-by: Amit Shah <a...@kernel.org>
