On Mon, Jul 22, 2024 at 04:32:23PM +0200, Philippe Mathieu-Daudé wrote: > On 22/7/24 15:16, Daniel P. Berrangé wrote: > > GNUTLS already supports dynamically enabling its logging at runtime by > > setting the env var 'GNUTLS_DEBUG_LEVEL=10', so there is no need to > > re-invent this logic in QEMU in a way that requires a re-compile. > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > --- > > crypto/init.c | 11 ----------- > > 1 file changed, 11 deletions(-) > > > > diff --git a/crypto/init.c b/crypto/init.c > > index fb7f1bff10..2d6dfa3091 100644 > > --- a/crypto/init.c > > +++ b/crypto/init.c > > @@ -34,13 +34,6 @@ > > #include "crypto/random.h" > > -/* #define DEBUG_GNUTLS */ > > Maybe mention GNUTLS_DEBUG_LEVEL=10 here or in header? Otherwise
I'm adding /* * To debug GNUTLS see env vars listed in * https://gnutls.org/manual/html_node/Debugging-and-auditing.html */ > > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
