On 2024/07/22 9:17, Michael S. Tsirkin wrote:
From: Akihiko Odaki <akihiko.od...@daynix.com>A SR-IOV VF cannot have a ROM BAR. Co-developed-by: Yui Washizu <yui.wash...@gmail.com> Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> Message-Id: <20240715-sriov-v5-1-3f5539093...@daynix.com> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> Signed-off-by: Michael S. Tsirkin <m...@redhat.com> --- hw/pci/pci.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4c7be52951..bd956637bc 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2359,6 +2359,14 @@ static void pci_add_option_rom(PCIDevice *pdev, bool is_default_rom, return; }+ if (pci_is_vf(pdev)) {+ if (pdev->rom_bar == ON_OFF_AUTO_ON) {
This requires: https://lore.kernel.org/r/20240714-rombar-v2-0-af1504ef5...@daynix.com ("[PATCH v2 0/4] hw/pci: Convert rom_bar into OnOffAuto") However it does not seem included in this pull request. Regards, Akihiko Odaki
