On Fri Jul 12, 2024 at 11:40 PM AEST, Cédric Le Goater wrote: > On 7/12/24 14:02, Nicholas Piggin wrote: > > diff --git a/target/ppc/timebase_helper.c b/target/ppc/timebase_helper.c > > index 39d397416e..52f9e6669c 100644 > > --- a/target/ppc/timebase_helper.c > > +++ b/target/ppc/timebase_helper.c > > @@ -19,6 +19,7 @@ > > #include "qemu/osdep.h" > > #include "cpu.h" > > #include "hw/ppc/ppc.h" > > +#include "hw/ppc/pnv_core.h" > > I am afraid this header file is pulling too much definitions for > qemu-user. It breaks compile.
Humph, sorry I obviously wasn't testing it. I might just ifdef it for now. Not sure the best way to do it cleanly in the longer term , Power specific things could go into their own helper.c file, but I don't necessarily like to move them away from similar/related functions. Thanks, Nick