On 05/07/2024 10:15, Zhao Liu wrote: >> There is a new user for cfmw_list now >> https://lore.kernel.org/qemu-devel/20240704093404.1848132-1-zhao1....@linux.intel.com/ >> >> So I think we should drop this patch.
> Hi Zhijian, > > I'm not a "real" user and that bug was originally found by code reading. > > So that fix won't block your drop. 🙂 "hw/cxl: Get rid of unused cfmw_list" is no longer needed. > > And I think the fix is worth being laned before cfmw_list gets dropped, > for being able to port backwards to stable QEMU. Your fix[0] requires CXLState.cfmw_list, and I think CXLState.cfmw_list was designed for *get* purpose but got mistake at that time. [0] https://lore.kernel.org/qemu-devel/20240704093404.1848132-1-zhao1....@linux.intel.com/ > >> On 02/07/2024 22:34, Jonathan Cameron wrote: >>> From: Li Zhijian<lizhij...@fujitsu.com> >>> >>> There is no user for this member. All '-M cxl-fmw.N' options have >>> been parsed and saved to CXLState.fixed_windows. >>> >>> Signed-off-by: Li Zhijian<lizhij...@fujitsu.com> >>> Signed-off-by: Jonathan Cameron<jonathan.came...@huawei.com> >>> --- >>> include/hw/cxl/cxl.h | 1 - >>> hw/cxl/cxl-host.c | 1 - >>> 2 files changed, 2 deletions(-) >>> >>> diff --git a/include/hw/cxl/cxl.h b/include/hw/cxl/cxl.h >>> index 75e47b6864..e3ecbef038 100644 >>> --- a/include/hw/cxl/cxl.h >>> +++ b/include/hw/cxl/cxl.h >>> @@ -43,7 +43,6 @@ typedef struct CXLState { >>> MemoryRegion host_mr; >>> unsigned int next_mr_idx; >>> GList *fixed_windows; >>> - CXLFixedMemoryWindowOptionsList *cfmw_list; >>> } CXLState; >>>
