Can I get review for this patch? Thanks,
Best regards, Amjad On Wed, Jun 12, 2024 at 08:43:21PM +0800, Amjad Alsharafi wrote: > These patches fix some bugs found when modifying files in vvfat. > First, there was a bug when writing to the cluster 2 or above of a file, it > will copy the cluster before it instead, so, when writing to cluster=2, the > content of cluster=1 will be copied into disk instead in its place. > > Another issue was modifying the clusters of a file and adding new > clusters, this showed 2 issues: > - If the new cluster is not immediately after the last cluster, it will > cause issues when reading from this file in the future. > - Generally, the usage of info.file.offset was incorrect, and the > system would crash on abort() when the file is modified and a new > cluster was added. > > Also, added some iotests for vvfat, covering the this fix and also > general behavior such as reading, writing, and creating files on the > filesystem. > Including tests for reading/writing the first cluster which > would pass even before this patch. > > v5: > - Fix a bug in reading non-contiguous clusters in vvfat for more than 2 > mappings. > - Added a test for adding more clusters where they are non-contiguous and > result in 3 mappings (for the above fix). > - Split PATCH 2/4 into 2 patches and a better fix for the `abort` issue > (now in PATCH 3/5). > - Other fixes and improvements in `fat16.py` module used for iotests. > > v4: > Applied some suggestions from Kevin Wolf <kw...@redhat.com>: > - Fixed code formatting by following the coding style in > `scripts/checkpatch.pl` > - Reduced changes related to `iotests` by setting `vvfat` format as > non-generic. > - Added another test to cover the fix done in `PATCH 2/4` and `PATCH 3/4` > for > handling reading/writing files with non-continuous clusters. > > v3: > Added test for creating new files in vvfat. > > v2: > Added iotests for `vvfat` driver along with a simple `fat16` module to run > the tests. > > v1: > https://patchew.org/QEMU/20240327201231.31046-1-amjadsharaf...@gmail.com/ > Fix the issue of writing to the middle of the file in vvfat > > Amjad Alsharafi (5): > vvfat: Fix bug in writing to middle of file > vvfat: Fix usage of `info.file.offset` > vvfat: Fix wrong checks for cluster mappings invariant > vvfat: Fix reading files with non-continuous clusters > iotests: Add `vvfat` tests > > block/vvfat.c | 47 +- > tests/qemu-iotests/check | 2 +- > tests/qemu-iotests/fat16.py | 673 +++++++++++++++++++++++++++++ > tests/qemu-iotests/testenv.py | 2 +- > tests/qemu-iotests/tests/vvfat | 457 ++++++++++++++++++++ > tests/qemu-iotests/tests/vvfat.out | 5 + > 6 files changed, 1164 insertions(+), 22 deletions(-) > create mode 100644 tests/qemu-iotests/fat16.py > create mode 100755 tests/qemu-iotests/tests/vvfat > create mode 100755 tests/qemu-iotests/tests/vvfat.out > > -- > 2.45.1 >
