On 03/29/12 22:56, Alon Levy wrote: > Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail.
Nice start (there are more guest-triggerable asserts to be fixed this way). > qxl_phys2virt requires an additional argument because all it's possible > return values are legit (well, I could use the fact it returns a pointer > so it should be word aligned but I don't want to go there, this is > totally internal). Really? What is bad with returning and checking for NULL? Guest memslots are backed by guest ram and should never ever resolve to a NULL pointer in qemu's process address space. cheers, Gerd
