On Wed, Jun 19, 2024 at 04:15:35PM +0200, Eric Auger wrote: > > @@ -209,12 +209,20 @@ static void acpi_dsdt_add_tpm(Aml *scope, > > VirtMachineState *vms) > > #define ROOT_COMPLEX_ENTRY_SIZE 36 > > #define IORT_NODE_OFFSET 48 > > > > +/* > > + * Input Output Remapping Table (IORT) -- Table 4 ID mapping format > > + * Conforms to "IO Remapping Table System Software on ARM Platforms", > > + * Document number: ARM DEN 0049E.b, Feb 2021 > I would rather explain what the function does, ie append an ID mapping > entry as desribed in Tabble 4 ID Mapping format. > > Also while at it you may use a more recent revision > There is DEN0049E_IO_Remapping_Table_E.f.pdf available
Sure. Will do a v4 with something like: +/* + * Append an ID mapping entry as described in "Table 4 ID mapping format" + * from "IO Remapping Table System Software on ARM Platforms", Chapter 3. + * Document number: ARM DEN 0049E.f, Apr 2024 > Reviewed-by: Eric Auger <eric.au...@redhat.com> Thanks for the review! Nicolin
