On Thu, Jun 13, 2024 at 10:31:50AM +0200, Thomas Huth wrote: > On 13/06/2024 07.22, Markus Armbruster wrote: > > Manos Pitsidianakis <manos.pitsidiana...@linaro.org> writes: > > > > > On Thu, 13 Jun 2024 06:26, Peng Fan <peng....@nxp.com> wrote: > > > > Hi All, > > > > > > > > The following files are marked as GPL-3.0-or-later. Will these > > > > Conflict with Qemu LICENSE? > > > > > > > > Should we update the files to GPL-2.0? > > > > > > > > ./tests/tcg/aarch64/semicall.h:7: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/x86_64/system/boot.S:13: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/riscv64/semicall.h:7: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/multiarch/float_convs.c:6: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/multiarch/float_helpers.h:6: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/multiarch/libs/float_helpers.c:10: * > > > > SPDX-License-Identifier: GPL-3.0-or-later > > > > ./tests/tcg/multiarch/arm-compat-semi/semihosting.c:7: * > > > > SPDX-License-Identifier: GPL-3.0-or-later > > > > ./tests/tcg/multiarch/arm-compat-semi/semiconsole.c:7: * > > > > SPDX-License-Identifier: GPL-3.0-or-later > > > > ./tests/tcg/multiarch/float_convd.c:6: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/multiarch/float_madds.c:6: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/i386/system/boot.S:10: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > ./tests/tcg/arm/semicall.h:7: * SPDX-License-Identifier: > > > > GPL-3.0-or-later > > > > > > > > Thanks, > > > > Peng. > > > > > > Hello Peng, > > > > > > These are all actually GPL-2.0-or-later, in fact I can't find the string > > > GPL-3.0-or-later in the current master at all. > > > > See commit 542b10bd148a (tests/tcg: update licenses to GPLv2 as intended). > > Maybe it could be included in the stable releases before 9.0, too? > CC:-ing qemu-stable for this now.
IMHO this is largely a non-issue from a licensing compatibility POV, and thus not neccessary for stable. This is self-contained test code that, IIUC, is not linking to the bits of QEMU that are GPLv-2-only, so is valid to have any license. GPL-2.0+ is just "nice to have" for consistency of the codebase. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
