Am 13.03.2024 um 16:28 hat Vladimir Sementsov-Ogievskiy geschrieben: > Add test for a new backup option: discard-source. > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> > Reviewed-by: Fiona Ebner <f.eb...@proxmox.com> > Tested-by: Fiona Ebner <f.eb...@proxmox.com>
This test fails for me, and it already does so after this commit that introduced it. I haven't checked what get_actual_size(), but I'm running on XFS, so its preallocation could be causing this. We generally avoid checking the number of allocated blocks in image files for this reason. Kevin backup-discard-source fail [19:45:49] [19:45:50] 0.8s failed, exit status 1 --- /home/kwolf/source/qemu/tests/qemu-iotests/tests/backup-discard-source.out +++ /home/kwolf/source/qemu/build-clang/scratch/qcow2-file-backup-discard-source/backup-discard-source.out.bad @@ -1,5 +1,14 @@ -.. +F. +====================================================================== +FAIL: test_discard_cbw (__main__.TestBackup.test_discard_cbw) +1. do backup(discard_source=True), which should inform +---------------------------------------------------------------------- +Traceback (most recent call last): + File "/home/kwolf/source/qemu/tests/qemu-iotests/tests/backup-discard-source", line 147, in test_discard_cbw + self.assertLess(get_actual_size(self.vm, 'temp'), 512 * 1024) +AssertionError: 1249280 not less than 524288 + ---------------------------------------------------------------------- Ran 2 tests -OK +FAILED (failures=1) Failures: backup-discard-source Failed 1 of 1 iotests
