On 27/5/24 12:49, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
---
  meson.build | 34 +++++++++++++++++++---------------
  1 file changed, 19 insertions(+), 15 deletions(-)


+  if emulator_modules.length() > 0
+    alias_target('modules', emulator_modules)
+  endif
  endif
nm = find_program('nm')
@@ -3745,19 +3762,6 @@ common_ss.add(hwcore)
  # Targets #
  ###########
-emulator_modules = []
-foreach m : block_mods + system_mods
-  emulator_modules += shared_module(m.name(),
-                build_by_default: true,
-                name_prefix: '',
-                link_whole: m,
-                install: true,
-                install_dir: qemu_moddir)
-endforeach
-if emulator_modules.length() > 0
-  alias_target('modules', emulator_modules)
-endif

In my experiment I moved this later after the qemu-system-FOO
meson targets, because I append libqemu-TARGET-softmmu objects;
but I guess this isn't a good start, and this patch LGTM.

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>


Reply via email to