On 03/27/2012 11:23 AM, Stefan Weil wrote: > Some locale settings let make fail or create wrong results > because tr '[:lower:]' '[:upper:]' which is used to convert > from lower to upper case depends on the locale. > ... > > v2: > POSIX says that 'tr a-z' is unspecified outside of the POSIX > locale, so we must set LC_ALL=C to make sure that we are using > POSIX (hint from Eric Blake, thanks). > > Signed-off-by: Stefan Weil <s...@weilnetz.de> > --- > configure | 6 +++--- > scripts/create_config | 6 +++--- > scripts/tracetool | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-)
Not being a regular reviewer on this list, I'm not sure I know the subtle difference between 'Acked-by' and 'Reviewed-by' to know which one I should be adding; but this patch resolves my objection on v1. [Side note - POSIX actually requires: tr a-z A-Z to do the 26-letter case conversion, and that use of '[a-z]' means you are transliterating 28 characters, by changing '[' and ']' to themselves. But on older Solaris tr, you had to provide the [] to get range expansion rather than transliteration of a literal '-', so your patch is the right approach for maximal portability] -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
