On Thu, Mar 7, 2024 at 12:36 PM Alvin Che-Chia Chang(張哲嘉) <alvi...@andestech.com> wrote: > > Hi Alistair, > > Please also take a look at this series, I guess it is ready to be applied, > thanks!
This is all acked now, do you mind rebasing on https://github.com/alistair23/qemu/tree/riscv-to-apply.next and sending a new version Alistair > > > BRs, > Alvin > > > -----Original Message----- > > From: Alvin Che-Chia Chang(張哲嘉) <alvi...@andestech.com> > > Sent: Tuesday, February 27, 2024 9:24 AM > > To: qemu-ri...@nongnu.org; qemu-devel@nongnu.org > > Cc: alistair.fran...@wdc.com; bin.m...@windriver.com; > > liwei1...@gmail.com; dbarb...@ventanamicro.com; > > zhiwei_...@linux.alibaba.com; Alvin Che-Chia Chang(張哲嘉) > > <alvi...@andestech.com> > > Subject: [PATCH v4 0/4] RISC-V: Modularize common match conditions for > > trigger > > > > According to RISC-V Debug specification ratified version 0.13 [1] (also > > applied > > to version 1.0 [2] but it has not been ratified yet), the enabled privilege > > levels > > of the trigger is common match conditions for all the types of the trigger. > > > > This series modularize the code for checking the privilege levels of type > > 2/3/6 > > triggers by implementing functions trigger_common_match() and > > trigger_priv_match(). > > > > Additional match conditions, such as CSR tcontrol and textra, can be further > > implemented into trigger_common_match() in the future. > > > > [1]: https://github.com/riscv/riscv-debug-spec/releases/tag/task_group_vote > > [2]: > > https://github.com/riscv/riscv-debug-spec/releases/tag/1.0.0-rc1-asciidoc > > > > Changes from v3: > > - Change this series to target Debug Spec. version 0.13 > > > > Changes from v2: > > - Explicitly mention the targeting version of RISC-V Debug Spec. > > > > Changes from v1: > > - Fix typo > > - Add commit description for changing behavior of looping the triggers > > when we check type 2 triggers. > > > > Alvin Chang (4): > > target/riscv: Add functions for common matching conditions of trigger > > target/riscv: Apply modularized matching conditions for breakpoint > > target/riscv: Apply modularized matching conditions for watchpoint > > target/riscv: Apply modularized matching conditions for icount trigger > > > > target/riscv/debug.c | 124 +++++++++++++++++++++++++++++-------------- > > 1 file changed, 83 insertions(+), 41 deletions(-) > > > > -- > > 2.34.1 > > CONFIDENTIALITY NOTICE: > > This e-mail (and its attachments) may contain confidential and legally > privileged information or information protected from disclosure. If you are > not the intended recipient, you are hereby notified that any disclosure, > copying, distribution, or use of the information contained herein is strictly > prohibited. In this case, please immediately notify the sender by return > e-mail, delete the message (and any accompanying documents) and destroy all > printed hard copies. Thank you for your cooperation. > > Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.