Re: [PATCH 41/41] target/sparc: Enable VIS4 feature bit

[Philippe Mathieu-Daudé]

On 2/3/24 06:16, Richard Henderson wrote:

Signed-off-by: Richard Henderson <richard.hender...@linaro.org>
---
  target/sparc/cpu.c | 3 +++
  1 file changed, 3 insertions(+)

@@ -882,6 +883,8 @@ static Property sparc_cpu_properties[] = {
                      CPU_FEATURE_BIT_VIS3, false),
      DEFINE_PROP_BIT("ima",      SPARCCPU, env.def.features,
                      CPU_FEATURE_BIT_IMA, false),
+    DEFINE_PROP_BIT("vis4",     SPARCCPU, env.def.features,
+                    CPU_FEATURE_BIT_VIS4, false),

I don't see any current CPU with this bit enabled. Nitpicking,
maybe use "Allow enabling VIS4 feature" as subject? (I suppose
you tried using -cpu foo,vis4=on).

Could we add the M7 to sparc_defs[]?

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>