On Thu, Mar 22, 2012 at 2:17 PM, Paolo Bonzini <pbonz...@redhat.com> wrote: > Il 22/03/2012 15:15, Benoît Canet ha scritto: >> >> I added this flag after seeing the following code in in bdrv_open_common. >> >> /* >> * Clear flags that are internal to the block layer before opening the >> * image. >> */ >> open_flags = flags & ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING); >> >> This lead me to believe that bs->open_flags != open_flags. > > Correct, see the first two patches in the series at > http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg03467.html
We mangle the flags but I guess what I'm asking is, does it even matter? Those two bits don't affect qed or qcow2 .bdrv_open(). If possible, I think we should use bs->open_flags. Stefan
