On 2024/04/29 16:05, Michael S. Tsirkin wrote:
On Sun, Apr 28, 2024 at 04:21:06PM +0900, Akihiko Odaki wrote:
Based-on: <20240428-rss-v10-0-73cbaa91a...@daynix.com>
("[PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements")
Some features are not always available, and virtio-net used to disable
them when not available even if the corresponding properties were
explicitly set to "on".
Convert feature properties to OnOffAuto so that the user can explicitly
tell QEMU to automatically select the value by setting them "auto".
QEMU will give an error if they are set "on".
Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com>
Should we maybe bite the bullet allow "auto" for all binary/boolean
properties? Just ignore "auto" if no one cares ATM.
It is not always obvious whether "auto" should be considered as "on" or
"off" for existing boolean properties. The properties this patch deals
with are to enable features so "auto" should be considered as "on" if
possible. However, other properties may mean to disable features, and in
such a case, "auto" should be considered as "off".
It may still make sense to accept "auto" for all virtio-net feature bits
for consistency. In particular, I left guest_rsc_ext property boolean
since nobody cares "auto" for that feature, but this can be converted to
OnOffAuto.
