Re: [PATCH 15/24] accel/tcg: Restrict IcountDecr and CPUTLB to TCG

[Richard Henderson]

On 4/28/24 15:14, Philippe Mathieu-Daudé wrote:

IcountDecr union, the CPUTLB* structures and the
"exec/tlb-common.h" header are only required for
TCG.

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---
  include/exec/tlb-common.h | 4 ++++
  include/hw/core/cpu.h     | 9 ++++++---
  2 files changed, 10 insertions(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.hender...@linaro.org>

Though you might mention can_do_io also being restricted:

@@ -346,6 +347,7 @@ typedef union IcountDecr {
   * @plugin_state: per-CPU plugin state
   */
  typedef struct CPUNegativeOffsetState {
+#ifdef CONFIG_TCG
      CPUTLB tlb;
  #ifdef CONFIG_PLUGIN
      /*
@@ -356,6 +358,7 @@ typedef struct CPUNegativeOffsetState {
  #endif
      IcountDecr icount_decr;
      bool can_do_io;
+#endif
  } CPUNegativeOffsetState;

struct KVMState;

r~