On Fri, 19 Apr 2024 at 17:30, Raphael Poggi <raphael.po...@lynxleap.co.uk> wrote: > > This commit allows childs clock to propagate their new frequency, > for example, after setting a new multiplier/diviser. > > Signed-off-by: Raphael Poggi <raphael.po...@lynxleap.co.uk>
Applied to target-arm.next, thanks. I rewrote the commit message to document the conversation we had in the other email thread: hw/core/clock: allow clock_propagate on child clocks clock_propagate() has an assert that clk->source is NULL, i.e. that you are calling it on a clock which has no source clock. This made sense in the original design where the only way for a clock's frequency to change if it had a source clock was when that source clock changed. However, we subsequently added multiplier/divider support, but didn't look at what that meant for propagation. If a clock-management device changes the multiplier or divider value on a clock, it needs to propagate that change down to child clocks, even if the clock has a source clock set. So the assertion is now incorrect. Remove the assertion. -- PMM