On Sat, 30 Mar 2024 at 10:33, Jinjie Ruan <ruanjin...@huawei.com> wrote: > > Added properties to enable FEAT_GICv3_NMI feature, setup distributor > and redistributor registers to indicate NMI support.
The subject line is misleading, since we don't actually enable the FEAT_GICv3_NMI feature here. I suggest: hw/intc/arm_gicv3: Add has-nmi property to GICv3 device Add a property has-nmi to the GICv3 device, and use this to set the NMI bit in the GICD_TYPER register. This isn't visible to guests yet because the property defaults to false and we won't set it in the board code until we've landed all of the changes needed to implement FEAT_GICV3_NMI. > Signed-off-by: Jinjie Ruan <ruanjin...@huawei.com> > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > --- Otherwise Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> thanks -- PMM
