26.03.2024 15:26, Igor Mammedov wrote:
QEMU build fails with hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy' when it's built with only 'microvm' enabled i.e. with config patch +++ b/configs/devices/i386-softmmu/default.mak @@ -26,7 +26,7 @@# Boards: # -CONFIG_ISAPC=y -CONFIG_I440FX=y -CONFIG_Q35=y +CONFIG_ISAPC=n +CONFIG_I440FX=n +CONFIG_Q35=n it happens because I've fogotten/lost smbios_get_table_legacy() stub. Fix it by adding missing stub as Philippe suggested. Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine" Reported-by: Michael Tokarev <m...@tls.msk.ru> Singned-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> Signed-off-by: Igor Mammedov <imamm...@redhat.com>
Reviewed-by: Michael Tokarev <m...@tls.msk.ru> Thanks, /mjt
