On Fri, 2024-03-22 at 17:28 +0100, Philippe Mathieu-Daudé wrote: > "cpu.h" is implicitly included. Include it explicitly to > avoid the following error when refactoring headers: > > hw/s390x/s390-stattrib.c:86:40: error: use of undeclared identifier > 'TARGET_PAGE_SIZE' > len = sac->peek_stattr(sas, addr / TARGET_PAGE_SIZE, buflen, > vals); > ^ > hw/s390x/s390-stattrib.c:94:58: error: use of undeclared identifier > 'TARGET_PAGE_MASK' > addr / TARGET_PAGE_SIZE, len, addr & > ~TARGET_PAGE_MASK); > ^ > hw/s390x/s390-stattrib.c:224:40: error: use of undeclared > identifier 'TARGET_PAGE_BITS' > qemu_put_be64(f, (start_gfn << TARGET_PAGE_BITS) | > STATTR_FLAG_MORE); > ^ > In file included from hw/s390x/s390-virtio-ccw.c:17: > hw/s390x/s390-virtio-hcall.h:22:27: error: unknown type name > 'CPUS390XState' > int s390_virtio_hypercall(CPUS390XState *env); > ^ > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > --- > hw/s390x/s390-virtio-hcall.h | 2 ++ > hw/s390x/s390-stattrib.c | 1 + > 2 files changed, 3 insertions(+)
These aren't the only implicit users of cpu.h in hw/s390x/ but if this solves one problem, then that's good. Acked-by: Eric Farman <far...@linux.ibm.com>
