On Wed, 20 Mar 2024 at 20:22, Felipe Balbi <ba...@kernel.org> wrote: > > Hi all, > > These two patches add support for STM32G0 family and nucleo-g071rb > board. Patches have been tested with minimal embedded rust examples. > > Changes since v1: > > - Patch 1: > - Convert tabs to spaces (checkpatch.pl) > - Correct lines longer than 80 characters (checkpatch.pl) > - Correct num-prio-bits (Samuel Tardieu) > - Correct num-irqs (Found reviewing RM0444) > > - Patch 2: > - Convert tabs to spaces (checkpatch.pl) > > Felipe Balbi (2): > hw/arm: Add support for stm32g000 SoC family > hw/arm: Add nucleo-g071rb board > > MAINTAINERS | 13 ++ > hw/arm/Kconfig | 12 ++ > hw/arm/meson.build | 2 + > hw/arm/nucleo-g071rb.c | 70 +++++++++ > hw/arm/stm32g000_soc.c | 253 +++++++++++++++++++++++++++++++++ > include/hw/arm/stm32g000_soc.h | 62 ++++++++
Hi; I've left review comments on the two patches in this series. There are a couple of "missing pieces" here: (1) documentation. Arm board documentation is in rst format in docs/system/arm/. You can either add the information for this board to the existing stm32.rst which documents the other STM32 boards we model, or if you think it's too different to share a source file you can create a new one with the same kind of structure. (Using the existing stm32.rst seems likely to be best to me.) (2) tests. Are there any conveniently publicly available guest images from some URL that doesn't mind our CI downloading from it, that would run on the board model as it is? If so, we could consider writing an avocado test (these live in tests/avocado/), which basically can do "run QEMU with this image and look for this output on the serial port". This is a "nice-to-have", not a requirement. thanks -- PMM
