On Fri, Mar 22, 2024, 9:51 AM Markus Armbruster <arm...@redhat.com> wrote:
> The doc comment documents an argument that doesn't exist. Would > fail compilation if it was marked up correctly. Delete. > > The Returns: section fails to refer to the data type, leaving the user > to guess. Fix that. > > The command name violates QAPI naming rules: it should be > query-migration-threads. Too late to fix. > > Reported-by: John Snow <js...@redhat.com> > Fixes: 671326201dac (migration: Introduce interface query-migrationthreads) > Signed-off-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> --- > qapi/migration.json | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/qapi/migration.json b/qapi/migration.json > index f6238b6980..e47ad7a63b 100644 > --- a/qapi/migration.json > +++ b/qapi/migration.json > @@ -2419,9 +2419,7 @@ > # > # Returns information of migration threads > # > -# data: migration thread name > -# > -# Returns: information about migration threads > +# Returns: @MigrationThreadInfo > # > # Since: 7.2 > ## > -- > 2.44.0 > >
