Hi Phlippe, > -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@linaro.org> > Sent: Wednesday, March 20, 2024 11:57 PM > To: Kim, Dongwon <dongwon....@intel.com>; qemu-devel@nongnu.org > Cc: marcandre.lur...@redhat.com > Subject: Re: [PATCH 0/3] ui/console: initialize QemuDmaBuf in ui/console > > Hi Dongwon, > > On 20/3/24 21:50, dongwon....@intel.com wrote: > > From: Dongwon Kim <dongwon....@intel.com> > > > > QemuDmaBuf struct is defined and primarily used by ui/console/gl so it > > is better to handle its creation, initialization and access within > > ui/console rather than within hw modules such as hw/display/virtio-gpu > > and hw/vfio/display. > > > > To achieve this, new methods for allocating, initializing the struct, > > and accessing certain fields necessary for hardware modules have been > > introduced in ui/console.c. > > (3rd patch) > > > > Furthermore, modifications have been made to hw/display/virtio-gpu and > > hw/vfio/display to utilize these new methods instead of setting up the > > struct independently. > > (1st and 2nd patches) > > Thanks for splitting, unfortunately the series isn't buildable / bisectable > since the > methods use in patches 1&2 are only introduced in patch 3 :/ [Kim, Dongwon] Maybe changing order of patches like 3-1-2 would be acceptable?
> > > Dongwon Kim (3): > > hw/virtio: intialize QemuDmaBuf using the function from ui/console > > hw/vfio: intialize QemuDmaBuf using the function from ui/console > > ui/console: add methods for allocating, intializing and accessing > > QemuDmaBuf
