On Thu, 29 Feb 2024 at 23:02, Richard Henderson <richard.hender...@linaro.org> wrote: > > On 2/29/24 03:10, Jinjie Ruan via wrote: > > + bool new_state = ((env->cp15.hcr_el2 & HCR_VI) && > > + (env->cp15.hcrx_el2 & HCRX_VINMI)) || > > + ((env->cp15.hcr_el2 & HCR_VF) && > > + (env->cp15.hcrx_el2 & HCRX_VFNMI)) || > > + (env->irq_line_state & CPU_INTERRUPT_VNMI); > > Because the GIC cannot signal an FIQ with superpriority, I think you should > not include VF > && VFNMI in CPU_INTERRUPT_VNMI.
The GIC can't, but a hypervisor can -- it just sets the VF and VFNMI bits if it wants one. (Architecturally, the CPU has a FIQ-with-superpriority, it's only the GIC that doesn't.) thanks -- PMM
