On Mon, 18 Mar 2024 10:29:28 +0800
Yuquan Wang <wangyuquan1...@phytium.com.cn> wrote:
> The dev_dbg info for Clear Event Records mailbox command would report
> the handle of the next record to clear not the current one.
>
> This was because the index 'i' had incremented before printing the
> current handle value.
>
> Signed-off-by: Yuquan Wang <wangyuquan1...@phytium.com.cn>
> ---
> drivers/cxl/core/mbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index 9adda4795eb7..b810a6aa3010 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -915,7 +915,7 @@ static int cxl_clear_event_record(struct cxl_memdev_state
> *mds,
>
> payload->handles[i++] = gen->hdr.handle;
> dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log,
> - le16_to_cpu(payload->handles[i]));
> + le16_to_cpu(payload->handles[i-1]));
Trivial but needs spaces around the -. e.g. [i - 1]
Maybe Dan can fix up whilst applying.
Otherwise
Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com>
>
> if (i == max_handles) {
> payload->nr_recs = i;
