On Mon, 11 Mar 2024 at 11:50, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Mon, 4 Mar 2024 at 01:28, <pet...@redhat.com> wrote: > > > > From: Fabiano Rosas <faro...@suse.de> > > > > If we receive a file descriptor that points to a regular file, there's > > nothing stopping us from doing multifd migration with mapped-ram to > > that file. > > > > Enable the fd: URI to work with multifd + mapped-ram. > > > > Note that the fds passed into multifd are duplicated because we want > > to avoid cross-thread effects when doing cleanup (i.e. close(fd)). The > > original fd doesn't need to be duplicated because monitor_get_fd() > > transfers ownership to the caller. > > > > Signed-off-by: Fabiano Rosas <faro...@suse.de> > > Reviewed-by: Peter Xu <pet...@redhat.com> > > Link: https://lore.kernel.org/r/20240229153017.2221-23-faro...@suse.de > > Signed-off-by: Peter Xu <pet...@redhat.com> > > Hi; Coverity points out some issues with this commit (CID 1539961, 1539965):
Oh, and also CID 1539960: there's a third instance of dup() with no error checking in another commit. thanks -- PMM
