On Tue, 5 Mar 2024 05:59:46 +0000 Ankit Agrawal <ank...@nvidia.com> wrote:
> > One thing I forgot. > > > > Please add a test. tests/qtest/bios-tables-test.c > > + relevant table dumps. > > Here I need to add a test that creates a vfio-pci device and numa > nodes and link using the acpi-generic-initiator object. One thing > here is that the -device vfio-pci needs a host=<bdf> argument. I > probably cannot provide the device bdf from my local setup. So > I am not sure how can I add this test to tests/qtest/bios-tables-test.c. > FYI, the following is a sample args we use for the > acpi-generic-initiator object. > > -numa node,nodeid=2 > -device vfio-pci-nohotplug,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \ > -object acpi-generic-initiator,id=gi0,pci-dev=dev0,node=2 \ > > Moreover based on a quick grep, I don't see any other test that > have -device vfio-pci argument. > > Jonathan, Alex, do you know how we may add tests that is dependent > on the vfio-pci device? > As Jonathan notes, we've decoupled this from vfio-pci, the pci-dev= arg can point to any PCI device. For example, any emulated PCI NIC could be a stand-in for the vfio-pci device used in practice. Thanks, Alex
