Pierrick Bouvier <pierrick.bouv...@linaro.org> writes: > On 2/29/24 11:08 AM, Alex Bennée wrote: >> Pierrick Bouvier <pierrick.bouv...@linaro.org> writes: >> >>> On 2/29/24 2:08 AM, Alex Bennée wrote: >>>> Luc Michel <luc.mic...@amd.com> writes: >>>> >>>>> Hi Pierrick, >>>>> >> <snip> >>>> >>> >>> My bad. Other plugins enable only inline when both are supplied, so I >>> missed this here. >>> I added an explicit error when user enable callback and inline at the >>> same time on this plugin. >> We could default to inline unless we need the more features of >> callbacks? >> > > This remark applies for all plugins in general. Now we have safe and > correct inline operations, callbacks are not needed in some case. > > Would that be acceptable for you that we delay this "cleanup" to > existing plugins after soft freeze? So we can focus on merging current > API changes needed.
As long as we fix the double reporting bug sure. -- Alex Bennée Virtualisation Tech Lead @ Linaro