On Tue, Feb 20, 2024 at 07:41:30PM -0300, Fabiano Rosas wrote: > Signed-off-by: Fabiano Rosas <faro...@suse.de>
Reviewed-by: Peter Xu <pet...@redhat.com> One question to double check with you: [...] > +#ifndef _WIN32 > + migration_test_add("/migration/multifd/fd/fixed-ram", > + test_multifd_fd_fixed_ram); > +#endif I know we mostly ever use _WIN32 to check these, but why not CONFIG_POSIX? commit d7613ee2165769303d0fa31069c4b6a840f0dae2 Author: Bin Meng <bin.m...@windriver.com> Date: Wed Aug 24 17:39:59 2022 +0800 tests/qtest: migration-test: Skip running test_migrate_fd_proto on win32 It wanted to avoid socketpair(), which makes sense. However e.g. qmp cmd "getfd" is with CONFIG_POSIX. -- Peter Xu