Steve Sistare <steven.sist...@oracle.com> writes: > A small number of migration options are accessed by migration clients, > but to see them clients must include all of options.h, which is mostly > for migration core code. migrate_mode() in particular will be needed by > multiple clients. > > Refactor the option declarations so clients can see the necessary few via > misc.h, which already exports a portion of the client API. > > Signed-off-by: Steve Sistare <steven.sist...@oracle.com> > --- > I suggest that eventually we should define a single file migration/client.h > which exports everything needed by the simpler clients: blockers, notifiers, > options, cpr, and state accessors. > --- > --- > hw/vfio/migration.c | 1 - > hw/virtio/virtio-balloon.c | 1 - > include/migration/misc.h | 1 + > include/migration/options-pub.h | 24 ++++++++++++++++++++++++ > migration/options.h | 6 +-----
Unusual naming. We have zero headers named -pub.h or -public.h, and dozens named like -int.h or -internal.h. Please stick to the existing convention. [...]
