Am 15.03.2012 08:35, schrieb Igor Mitsyanko: > Create 9 exynos4210 i2c interfaces. > > Signed-off-by: Igor Mitsyanko <i.mitsya...@samsung.com>
Reviewed-by: Andreas Färber <afaer...@suse.de> for the non-technical aspects. One remark below. > diff --git a/hw/exynos4210_i2c.c b/hw/exynos4210_i2c.c > new file mode 100644 > index 0000000..42f770d > --- /dev/null > +++ b/hw/exynos4210_i2c.c > +enum { > + idle, > + start_bit_received, > + sending_data, > + receiving_data > +}; Usually our enum values are uppercase, not sure if that's a rule. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg