On Mon, Feb 26, 2024 at 11:16 AM Alvin Che-Chia Chang(張哲嘉) <alvi...@andestech.com> wrote: > > Hi Alistair, > > > -----Original Message----- > > From: Alistair Francis <alistai...@gmail.com> > > Sent: Monday, February 26, 2024 8:25 AM > > To: Alvin Che-Chia Chang(張哲嘉) <alvi...@andestech.com> > > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > > alistair.fran...@wdc.com; bin.m...@windriver.com; liwei1...@gmail.com; > > dbarb...@ventanamicro.com; zhiwei_...@linux.alibaba.com > > Subject: Re: [PATCH v2 0/4] RISC-V: Modularize common match conditions for > > trigger > > > > [EXTERNAL MAIL 外部信件] > > > > On Fri, Feb 23, 2024 at 12:22 PM Alvin Chang via <qemu-devel@nongnu.org> > > wrote: > > > > > > According to RISC-V Debug specification, the enabled privilege levels > > > of > > > > Can you specify what version of the debug spec? > > In general, this series does not add any new functionalities. > The original implementation has duplicated code in type 2/3/6 triggers. > I just eliminated those code and modularized them to be > trigger_common_match(). > Besides, we may want to check other conditions in the future, so this > function can be used for those purposes.
Ah, you are right. I just skimmed the message > > When I track the commit history, it seems the code is submitted in the > following commits two years ago: > https://github.com/qemu/qemu/commit/95799e36c15a9ab602a388491c40f6860f6ae8bf > https://github.com/qemu/qemu/commit/b5f6379d134bd201d52380c73ff73565e6a4321e > https://github.com/qemu/qemu/commit/c32461d8eeb17490b1b1e969e2ce8f1ecd83bfbb > https://github.com/qemu/qemu/commit/c472c142a7552f5b0e40378d5643a2810ef1b111 > > Since they mentioned the "type 6" trigger and "Sdtrig" extension, I assume > current implementation is based on Debug Spec version 1.0 > There is no type 6 trigger and Sdtrig extension in Debug Spec version 0.13 Yeah, we are a weird mix-match of the two unfortunately. Which is why I wanted to be explicit about which debug spec version you are targeting. > > Sincerely, > Alvin Chang > > > > > Ideally if you can link directly to the PDF that would be very useful. > > There are multiple versions so it's hard to keep track of. > > > > Alistair > > > > > the trigger is common match conditions for all the types of the trigger. > > > This series modularize the code for checking the privilege levels of > > > type 2/3/6 triggers by implementing functions trigger_common_match() > > > and trigger_priv_match(). > > > > > > Additional match conditions, such as CSR tcontrol and textra, can be > > > further implemented into trigger_common_match() in the future. > > > > > > Changes from v1: > > > - Fix typo > > > - Add commit description for changing behavior of looping the triggers > > > when we check type 2 triggers. > > > > > > Alvin Chang (4): > > > target/riscv: Add functions for common matching conditions of trigger > > > target/riscv: Apply modularized matching conditions for breakpoint > > > target/riscv: Apply modularized matching conditions for watchpoint > > > target/riscv: Apply modularized matching conditions for icount > > > trigger > > > > > > target/riscv/debug.c | 124 > > > +++++++++++++++++++++++++++++-------------- > > > 1 file changed, 83 insertions(+), 41 deletions(-) > > > > > > -- > > > 2.34.1 > > > > > > > CONFIDENTIALITY NOTICE: > > This e-mail (and its attachments) may contain confidential and legally > privileged information or information protected from disclosure. If you are > not the intended recipient, you are hereby notified that any disclosure, > copying, distribution, or use of the information contained herein is strictly > prohibited. In this case, please immediately notify the sender by return > e-mail, delete the message (and any accompanying documents) and destroy all > printed hard copies. Thank you for your cooperation. > > Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved. I'm not sure what you want me to do here Alistair
