23.02.2024 18:55, Peter Maydell:
On Sun, 18 Feb 2024 at 09:32, Michael Tokarev <m...@tls.msk.ru> wrote:
09.09.2023 16:23, Michael Tokarev :
A friendly ping?
A friendly ping #2?
Looking at the patch, the commit message lists 9
separate things it does. That suggests it ought to be
a 9-patch patchset, not a single patch. I bet most of
those 9 would be much easier to review than this, too...
When I was doing that, I tried to split things up. But it's..
difficult. Having in mind the amount of issues this script
has.
Trying to make small changes would be a huge work.
All the mentioned points (well, most) are the effect of an
almost rewrite. I tried to switch to this script in debian
(from the debian-specific thing which was used as a prototype
for qemu-binfmt-conf.sh) but failed, that was the result of
a minimal cleanup..
And yes, I know it's difficult to review. There's a trade-off -
either make it good, or make it easier to review ;)
Dunno what to do with it now :)
Thanks,
/mjt
