On Sat, 24 Feb 2024 at 01:06, Richard Henderson <richard.hender...@linaro.org> wrote: > > v2: Fix bsd-user build errors. > > > r~ > > > The following changes since commit 3d54cbf269d63ff1d500b35b2bcf4565ff8ad485: > > Merge tag 'hw-misc-20240222' of https://github.com/philmd/qemu into staging > (2024-02-22 15:44:29 +0000) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20240222-2 > > for you to fetch changes up to fcc6ad372f56d3f47b6d5457a904916b48b9e114: > > linux-user: Remove pgb_dynamic alignment assertion (2024-02-23 15:07:03 > -0800) > > ---------------------------------------------------------------- > tcg/aarch64: Apple does not align __int128_t in even registers > accel/tcg: Fixes for page tables in mmio memory > linux-user: Remove qemu_host_page_{size,mask}, HOST_PAGE_ALIGN > migration: Remove qemu_host_page_size > hw/tpm: Remove qemu_host_page_size > softmmu: Remove qemu_host_page_{size,mask}, HOST_PAGE_ALIGN > linux-user: Split and reorganize target_mmap. > *-user: Deprecate and disable -p pagesize > linux-user: Allow TARGET_PAGE_BITS_VARY > target/alpha: Enable TARGET_PAGE_BITS_VARY for user-only > target/arm: Enable TARGET_PAGE_BITS_VARY for AArch64 user-only > target/ppc: Enable TARGET_PAGE_BITS_VARY for user-only > linux-user: Remove pgb_dynamic alignment assertion > > ----------------------------------------------------------------
Hi -- looks like this introduces an new variable-length-array, which we are trying to get rid of: ../linux-user/elfload.c: In function 'vma_dump_size': ../linux-user/elfload.c:4254:9: error: ISO C90 forbids variable length array 'page' [-Werror=vla] 4254 | char page[TARGET_PAGE_SIZE]; | ^~~~ ../linux-user/elfload.c: In function 'elf_core_dump': ../linux-user/elfload.c:4778:13: error: ISO C90 forbids variable length array 'page' [-Werror=vla] 4778 | char page[TARGET_PAGE_SIZE]; | ^~~~ I noticed this because I happened to test merging this pullreq together with Thomas's testing pullreq that enforces the -Wvla error. I'll be merging that testing pull shortly but it's not upstream quite yet. thanks -- PMM
