On 8/2/24 23:03, Bernhard Beschow wrote:
Rather than distributing PC system flash handling across three files, let's confine it to one. Now, pc_system_firmware_init() creates, configures and cleans up the system flash which makes the code easier to understand. It also avoids the extra call to pc_system_flash_cleanup_unused() in the Xen case.
Maybe add " because pc_memory_init() is not called by Xen."
Signed-off-by: Bernhard Beschow <shen...@gmail.com> --- include/hw/i386/pc.h | 2 -- hw/i386/pc.c | 1 - hw/i386/pc_piix.c | 1 - hw/i386/pc_sysfw.c | 6 ++++-- 4 files changed, 4 insertions(+), 6 deletions(-)
Nice! Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
