On 2/17/24 02:13, Alexander Monakov wrote:
On Fri, 16 Feb 2024, Richard Henderson wrote:
Split less-than and greater-than 256 cases.
Use unaligned accesses for head and tail.
Avoid using out-of-bounds pointers in loop boundary conditions.
I guess it did not carry
typedef uint64_t uint64_a __attribute__((may_alias));
along the way, not a big deal since Qemu builds with -fno-strict-aliasing,
but I felt it was nice to be explicit in the code about that.
I suppose. My thought was that because of -fno-strict-aliasing, we don't care about
aliasing anywhere else in the code base, and then explicitly caring about it here could
cause confusion.
Am I expected to give Reviewed-by's to you? I did read the code to the
best of my ability and did not spot any issues.
r-b is not necessary, though thanks for the review.
+ /*
+ * Use unaligned memory access functions to handle
+ * the beginning and end of the buffer, with a couple
+ * of loops handling the middle aligned section.
+ */
... here, there is only one loop now, not two,
Thanks. Fixed.
r~
