> > > #endif > > > diff --git a/include/hw/cxl/cxl_events.h b/include/hw/cxl/cxl_events.h > > > index d778487b7e..4f8cb3215d 100644 > > > --- a/include/hw/cxl/cxl_events.h > > > +++ b/include/hw/cxl/cxl_events.h > > > @@ -166,4 +166,19 @@ typedef struct CXLEventMemoryModule { > > > uint8_t reserved[0x3d]; > > > } QEMU_PACKED CXLEventMemoryModule; > > > > > > +/* > > > + * CXL r3.0 section Table 8-47: Dynamic Capacity Event Record > > > + * All fields little endian. > > > + */ > > > +typedef struct CXLEventDynamicCapacity { > > > + CXLEventRecordHdr hdr; > > > + uint8_t type; > > > + uint8_t reserved1; > > > + uint16_t host_id; > > > + uint8_t updated_region_id; > > > + uint8_t reserved2[3]; > > > + uint8_t dynamic_capacity_extent[0x28]; /* defined in cxl_device.h */ > > > > > > > Can't we use that definition here? > > REPLY: > > I leave it as it is to avoid include cxl_device.h to cxl_extent.h. > > Do you think we need to include the file and use the definition here?
I don't feel strongly either way. Jonathan > > Fan