On Thu, 8 Feb 2024 at 18:14, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > Inline cpu_create() in order to call > qdev_init_gpio_in_named_with_opaque() > before the CPU is realized. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > --- > hw/sparc/leon3.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c > index 0df5fc949d..0e1d749306 100644 > --- a/hw/sparc/leon3.c > +++ b/hw/sparc/leon3.c > @@ -234,8 +234,11 @@ static void leon3_generic_hw_init(MachineState *machine) > APBPnp *apb_pnp; > > /* Init CPU */ > - cpu = SPARC_CPU(cpu_create(machine->cpu_type)); > + cpu = SPARC_CPU(object_new(machine->cpu_type)); > env = &cpu->env; > + qdev_init_gpio_in_named_with_opaque(DEVICE(cpu), leon3_set_pil_in, > + env, "pil", 1); > + qdev_realize(DEVICE(cpu), NULL, &error_fatal);
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> with a similar caveat as with the sparc64.c patch. thanks -- PMM
