Re: [PATCH 05/14] vfio: Add Error** argument to .set_dirty_page_tracking() handler

[Philippe Mathieu-Daudé]

On 7/2/24 14:33, Cédric Le Goater wrote:

We will use the Error object to improve error reporting in the
.log_global*() handlers of VFIO.

Signed-off-by: Cédric Le Goater <c...@redhat.com>
---
  include/hw/vfio/vfio-container-base.h | 4 ++--
  hw/vfio/common.c                      | 4 ++--
  hw/vfio/container-base.c              | 4 ++--
  hw/vfio/container.c                   | 6 +++---
  4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/include/hw/vfio/vfio-container-base.h 
b/include/hw/vfio/vfio-container-base.h
index 
b2813b0c117985425c842d91f011bb895955d738..f22fcb5a214be2717b42815371346401bb7fce51
 100644
--- a/include/hw/vfio/vfio-container-base.h
+++ b/include/hw/vfio/vfio-container-base.h
@@ -81,7 +81,7 @@ int vfio_container_add_section_window(VFIOContainerBase 
*bcontainer,
  void vfio_container_del_section_window(VFIOContainerBase *bcontainer,
                                         MemoryRegionSection *section);
  int vfio_container_set_dirty_page_tracking(VFIOContainerBase *bcontainer,
-                                           bool start);
+                                           bool start, Error **errp);

Since here, please document modified prototypes, otherwise:

Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>

  int vfio_container_query_dirty_bitmap(const VFIOContainerBase *bcontainer,
                                        VFIOBitmap *vbmap,
                                        hwaddr iova, hwaddr size);
@@ -122,7 +122,7 @@ struct VFIOIOMMUClass {
      void (*detach_device)(VFIODevice *vbasedev);
      /* migration feature */
      int (*set_dirty_page_tracking)(const VFIOContainerBase *bcontainer,
-                                   bool start);
+                                   bool start, Error **errp);
      int (*query_dirty_bitmap)(const VFIOContainerBase *bcontainer,
                                VFIOBitmap *vbmap,
                                hwaddr iova, hwaddr size);