On Tue, Feb 06, 2024 at 05:38:35AM -0800, Andrea Bolognani wrote: > On Tue, Feb 06, 2024 at 10:10:02AM +0800, Xianglai Li wrote: > > The UEFI loading mode in loongarch is very different > > from that in other architectures:loongarch's UEFI code > > is in rom, while other architectures' UEFI code is in flash. > > > > loongarch UEFI can be loaded as follows: > > -machine virt,pflash=pflash0-format > > -bios ./QEMU_EFI.fd > > > > Other architectures load UEFI using the following methods: > > -machine virt,pflash0=pflash0-format,pflash1=pflash1-format > > > > loongarch's UEFI loading method makes qemu and libvirt incompatible > > when using NVRAM, and the cost of loongarch's current loading method > > far outweighs the benefits, so we decided to use the same UEFI loading > > scheme as other architectures. > > > > Cc: Andrea Bolognani <abolo...@redhat.com> > > Cc: maob...@loongson.cn > > Cc: Philippe Mathieu-Daudé <phi...@linaro.org> > > Cc: Song Gao <gaos...@loongson.cn> > > Cc: zhaotian...@loongson.cn > > Signed-off-by: Xianglai Li <lixiang...@loongson.cn> > > --- > > hw/loongarch/acpi-build.c | 29 +++++++++-- > > hw/loongarch/virt.c | 101 ++++++++++++++++++++++++++---------- > > include/hw/loongarch/virt.h | 10 ++-- > > 3 files changed, 107 insertions(+), 33 deletions(-) > > For future reference, it's usually good practice to keep track of > changes between subsequent versions of the same patchset. > > Can you please confirm that the build of edk2 added with [1] is > intended to work with a version of QEMU that contains these changes? > I'd like to test things out as soon as I get a moment.
I've tried it now with libvirt and everything worked just as I expected it to, so Tested-by: Andrea Bolognani <abolo...@redhat.com> Were changes to edk2 necessary to make it boot from pflash instead of rom? If so, have those patches already been posted? -- Andrea Bolognani / Red Hat / Virtualization