On Thu, 1 Feb 2024 at 16:07, David Woodhouse <dw...@infradead.org> wrote: > > On Thu, 2024-02-01 at 11:30 +0100, Thomas Huth wrote: > > On 31/01/2024 15.18, David Woodhouse wrote: > > > On Wed, 2024-01-31 at 13:18 +0100, Thomas Huth wrote: > > > > Don't we have to change nd->macaddr.a[0 to 2] with this hard-coded > > > > MAC-prefix, too? > > > > > > I don't think so. > > > > > > We either get the MAC address from 'nd' if that exists, or generate a > > > new MAC address with qemu_macaddr_default_if_unset(). > > > > > > Then we override the OUI in the actual device. We don't care about 'nd' > > > any more at that point. > > > > I just double-checked, and yes, you're right, so: > > > > Reviewed-by: Thomas Huth <th...@redhat.com> > > Thank you, just just about completes my set. Every patch now has a > Reviewed-by: except two of them (hw/s390x/s390-virtio-ccw and > hw/arm/aspeed) which only have an Acked-by: > > I think according to The Rules I just need a maintainer to *tell* me to > send a pull request and then I'm allowed to do so?
Yeah, go ahead and send a pullreq for this. (I have a new board model brewing so it would be handy for me to have the new functions upstream so I can create the ethernet device in the right way :-)) thanks -- PMM
