I tested the unit test cases with "make check" and result looks good.
Tested-by: Xiaoling Song <xiaoling.s...@intel.com> Regards, Xiaoling On 1/18/2024 10:48 PM, Zhao Liu wrote:
From: Zhao Liu<zhao1....@intel.com> Hi list, Currently, test-smp-parse lacks the following cases: * The case to cover drawer and book parameters parsing in -smp. * The case to cover the full topology (with total 7 levels) to ensure that the topology-related calculations are correct. * The case to check smp_props.has_clusters of MachineClass. Thus, add the above cases to improve test coverage. In addition, people is trying to bump max_cpus to 4096 for PC machine [1]. Without considering other changes, it's only a matter of time before the maximum CPUs is raised. Therefore, aslo bump max_cpus to 4096 in -smp related test cases as a start. [1]:https://lore.kernel.org/qemu-devel/20231208122611.32311-1-anisi...@redhat.com/ Regards, Zhao --- Zhao Liu (8): tests/unit/test-smp-parse.c: Use CPU number macros in invalid topology case tests/unit/test-smp-parse.c: Bump max_cpus to 4096 tests/unit/test-smp-parse.c: Make test cases aware of the book/drawer tests/unit/test-smp-parse.c: Test "books" parameter in -smp tests/unit/test-smp-parse.c: Test "drawers" parameter in -smp tests/unit/test-smp-parse.c: Test "drawers" and "books" combination case tests/unit/test-smp-parse.c: Test the full 7-levels topology hierarchy tests/unit/test-smp-parse.c: Test smp_props.has_clusters tests/unit/test-smp-parse.c | 515 ++++++++++++++++++++++++++++++++++-- 1 file changed, 494 insertions(+), 21 deletions(-)
