On Tue, 19 Dec 2023 at 16:11, Peter Maydell <peter.mayd...@linaro.org> wrote: > > On Fri, 8 Dec 2023 at 02:32, Sergey Kambalin <serg.o...@gmail.com> wrote: > > > > Introducing Raspberry Pi 4B model. > > It contains new BCM2838 SoC, PCIE subsystem, > > RNG200, Thermal sensor and Genet network controller. > > > > It can work with recent linux kernels 6.x.x. > > Two avocado tests was added to check that. > > > > Unit tests has been made as read/write operations > > via mailbox properties. > > > > Genet integration test is under development. > > > > Every single commit > > 1) builds without errors > > 2) passes regression tests > > 3) passes style check* > > *the only exception is bcm2838-mbox-property-test.c file > > containing heavy macros usage which cause a lot of > > false-positives of checkpatch.pl. > > > > I did my best to keep the commits less than 200 changes, > > but had to make some of them a bit more in order to > > keep their integrity. > > > > This is v2 patchset with the most of v1 remarks fixed. > > I named it as 'v4' because of mistakes while attempts to send previous > > patchsets > > Please ignore all other v1...v3 patchsets except the very first one. > > Thanks for the rework and resending these patches. As > you've probably seen, I've reviewed patches 1-10, but > I won't have time to do more than that before I break > for the holiday season now; I will get back to the > rest of the series in January.
I'm now done with my review of this v4. I haven't left comments on every patch, but I have read through the others (including the ethernet controller ones) and I didn't see anything obviously wrong beyond what we've already discussed in this thread. I'll do a more full review for v5. thanks -- PMM
