On Fri, Dec 8, 2023 at 2:51 AM Si-Wei Liu <si-wei....@oracle.com> wrote: > > For better debuggability and observability. > > Signed-off-by: Si-Wei Liu <si-wei....@oracle.com> > --- > net/trace-events | 1 + > net/vhost-vdpa.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/net/trace-events b/net/trace-events > index be087e6..c128cc4 100644 > --- a/net/trace-events > +++ b/net/trace-events > @@ -30,3 +30,4 @@ vhost_vdpa_net_data_eval_flush(void *s, int qindex, int > svq_switch, bool svq_flu > vhost_vdpa_net_cvq_eval_flush(void *s, int qindex, int svq_switch, bool > svq_flush) "vhost_vdpa: %p qp: %d svq_switch: %d flush_map: %d" > vhost_vdpa_net_load_cmd(void *s, uint8_t class, uint8_t cmd, int data_num, > int data_size) "vdpa state: %p class: %u cmd: %u sg_num: %d size: %d" > vhost_vdpa_net_load_cmd_retval(void *s, uint8_t class, uint8_t cmd, int r) > "vdpa state: %p class: %u cmd: %u retval: %d" > +vhost_vdpa_net_load_mq(void *s, int ncurqps) "vdpa state: %p current_qpairs: > %d"
Similarly, I think nc->name looks better than the plain pointer here? Thanks > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 61da8b4..17b8d01 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -1109,6 +1109,8 @@ static int vhost_vdpa_net_load_mq(VhostVDPAState *s, > return 0; > } > > + trace_vhost_vdpa_net_load_mq(s, n->curr_queue_pairs); > + > mq.virtqueue_pairs = cpu_to_le16(n->curr_queue_pairs); > const struct iovec data = { > .iov_base = &mq, > -- > 1.8.3.1 >