On Fri, 5 Jan 2024 at 15:46, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > From: Gavin Shan <gs...@redhat.com> > > Set mc->valid_cpu_types so that the user specified CPU type can be > validated in machine_run_board_init(). We needn't to do the check > by ourselves.
Hi; after this change if you try to use the 'virt' board from qemu-system-arm with an invalid CPU type you get an odd error message full of "(null)"s: $ ./build/x86/qemu-system-arm -machine virt -cpu cortex-a9 qemu-system-arm: Invalid CPU model: cortex-a9 The valid models are: cortex-a7, cortex-a15, (null), (null), (null), (null), (null), (null), (null), (null), (null), (null), (null), max This seems to be because we print a "(null)" for every 64-bit only CPU in the list, instead of either ignoring them or not compiling them into the list in the first place. https://gitlab.com/qemu-project/qemu/-/issues/2084 thanks -- PMM