On 11.03.2012 19:01, Paolo Bonzini wrote: > Il 11/03/2012 02:49, Michael Tokarev ha scritto: >> The same as for non-coroutine versions in previous patches: >> rename arguments to be more obvious, change type of arguments >> from int to size_t where appropriate, and use common code for >> send and receive paths (with one extra argument) since these >> are exactly the same. Use common qemu_sendv_recvv() directly. >> Also constify buf arg of qemu_co_send(). >> >> qemu_co_sendv(), qemu_co_recvv(), and qemu_co_recv() are now >> trivial #define's merely adding one extra arg. qemu_co_send() >> is an inline function due to `buf' arg de-constification. > > Again, I don't see the point in using #defines. Either leave the > function static, or you can export it but then inlines are preferrable.
When you're debugging in gdb, it always enters all inline functions. For a very simple #define there's nothing to enter -- hence the #define. Note that - I still hope - in the end there will be no sendv or recv calls at all, only common sendv_recvv with is_write passed as an argument from upper layer. It will be easier to remove that #define - just two lines of code instead of minimum 5 :) Also, in such cases like these, #defines are more compact and does not clutter the header too much. >> qemu_co_sendv() and qemu_co_recvv() callers are converted to >> different argument order. > > Paolo Thanks, /mjt
