Am 25.02.2012 14:50, schrieb Stefan Weil: > Without the break statement, case 5 sets month and year from the same > data. This does not look correct. > > The missing break was reported by splint. > > Signed-off-by: Stefan Weil <s...@weilnetz.de>
Assigning data to both month and year certainly makes no sense, Reviewed-by: Andreas Färber <afaer...@suse.de> Andreas > --- > hw/ds1338.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/hw/ds1338.c b/hw/ds1338.c > index 6397f0a..d590d9c 100644 > --- a/hw/ds1338.c > +++ b/hw/ds1338.c > @@ -100,6 +100,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data) > break; > case 5: > s->now.tm_mon = from_bcd(data & 0x1f) - 1; > + break; > case 6: > s->now.tm_year = from_bcd(data) + 100; > break; -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
