Thank you a lot for the review Peter!
May I kindly ask you to take just a brief look at the first patches of GENET? I'd like to know if I've chosen the right way to replace bitfields with QEMU REG32/FIELD32 macros. Thanks, Sergey Kambalin Software Developer, Auriga Inc. ________________________________ От: Peter Maydell <peter.mayd...@linaro.org> Отправлено: 19 декабря 2023 г. 10:11:43 Кому: Sergey Kambalin Копия: qemu-...@nongnu.org; qemu-devel@nongnu.org; Kambalin, Sergey Тема: Re: [PATCH v4 00/45] Raspberry Pi 4B machine On Fri, 8 Dec 2023 at 02:32, Sergey Kambalin <serg.o...@gmail.com> wrote: > > Introducing Raspberry Pi 4B model. > It contains new BCM2838 SoC, PCIE subsystem, > RNG200, Thermal sensor and Genet network controller. > > It can work with recent linux kernels 6.x.x. > Two avocado tests was added to check that. > > Unit tests has been made as read/write operations > via mailbox properties. > > Genet integration test is under development. > > Every single commit > 1) builds without errors > 2) passes regression tests > 3) passes style check* > *the only exception is bcm2838-mbox-property-test.c file > containing heavy macros usage which cause a lot of > false-positives of checkpatch.pl. > > I did my best to keep the commits less than 200 changes, > but had to make some of them a bit more in order to > keep their integrity. > > This is v2 patchset with the most of v1 remarks fixed. > I named it as 'v4' because of mistakes while attempts to send previous > patchsets > Please ignore all other v1...v3 patchsets except the very first one. Thanks for the rework and resending these patches. As you've probably seen, I've reviewed patches 1-10, but I won't have time to do more than that before I break for the holiday season now; I will get back to the rest of the series in January. -- PMM
