On Thu, 14 Dec 2023 at 17:14, Philippe Mathieu-Daudé <phi...@linaro.org> wrote: > > QOM properties are added on the ARM vCPU object when a > feature is present. Rather than checking the property > is present, check the feature. > > Suggested-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org> > --- > RFC: If there is no objection on this patch, I can split > as a per-feature series if necessary. > > Based-on: <20231123143813.42632-1-phi...@linaro.org> > "hw: Simplify accesses to CPUState::'start-powered-off' property"
I'm not a super-fan of board-level code looking inside the QOM object with direct use of arm_feature() when it doesn't have to. What's wrong with asking whether the property exists before trying to set it? thanks -- PMM
